Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/8309/
• CommitID: ac66566
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/8310/
• CommitID: 9fd9d7a
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/8311/
• CommitID: 9682a84
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/8312/
• CommitID: c340120
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/8313/
• CommitID: 87106b7
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/8315/
• CommitID: 8683c54
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/8316/
• CommitID: 303a24e
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/8552/
• CommitID: b22d663
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/8553/
• CommitID: 735334d
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/8554/
• CommitID: 524c05f
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/8555/
• CommitID: a5c9db0

@DarshitChanpura @cwperks This finally passed, but I am not thrilled about the license setup that I had to do. I thought that we could share licenses across modules so that authn and identity could use the same license but I could not get that to work so eventually just did it manually. If either of you know how to fix the sharing configuration let me know. Otherwise this should be all set. I can also squash the commits when doing this.

@scrawfor99 It depends on which build.gradle file the dependency is in. The sha, LICENSE and NOTICE files should be in the build.gradle file of the project where the corresponding implementation or api dependency line is located.

In our case the identity module depends on the opensearch-authn library so since the cxf dependencies are in identity that's where the files should be so what you have done looks good to me.

For anyone reading this and wondering why there is both identity and opensearch-authn, its first had to do with how feature/identity has changed over time as we figure out a way to sandbox the changes and get ready for a merge with main down the line. feature/identity started as classes in an identity package under server, but then moved to sandbox where experimental code should go before being promoted to a main feature. Some code in the package migrated to the sandbox/opensearch-authn lib and the lib was added as a dependency to server so that the classes were importable. Most recently, the identity module was introduced and the opensearch-authn dependency on server was removed to keep the changes in this feature branch isolated from the server. opensearch-authn may be removed in the future and the classes there moved into the identity module. There may be a library introduced in the future for other modules and plugins to use identity features conveniently.

Hi @cwperks, thank you for the explanation. I was not sure what the difference between the two modules was myself so I appreciate you clearing that up. I will say that the dependencies are listed in both authn and identity--which seems like a mistake on my part given your explanation. I am going to remove them from identity and swap the api tag in the identity build.gradle over to an implementation as this should make the module inherit the transitive dependencies in authn.

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/8565/
• CommitID: 874d100
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/8566/
• CommitID: 891b9f1
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/8567/
• CommitID: f19fdac
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/8570/
• CommitID: 15e3019

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.action.admin.indices.create.ShrinkIndexIT.testCreateShrinkIndex

• URL: https://build.ci.opensearch.org/job/gradle-check/8735/
• CommitID: 518848b
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@peternied Can you please review and merge this change once you get a chance?

@cwperks I'm not sure if all your comments were fully addressed, happy to review follow up PRs or follow up issues if you'd still like to see more changes.

@peternied, I believe all of @cwperks have been addressed. The only unresolved one that I am aware of is the potential merging of the identity and authn substructures which will require a separate initiative.